Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window undefined issue #176

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Conversation

KatiaGhezali
Copy link
Collaborator

@KatiaGhezali KatiaGhezali commented Nov 27, 2023

Pull Request Title

Fix Window Undefined Bug in Map Component

Pull Request Description

The error encountered was due to the fact that react-leaflet relies on the Leaflet library, and server-side rendering (SSR) is incompatible with Leaflet.

Changes Made

  • Investigated the root cause of the window undefined bug.

  • Identified the specific part of the code causing the issue.

  • Temporarily replaced Firebase data retrieval with hardcoded information.

  • Tested the map component to ensure the bug is resolved.

  • Checked if the hardcoded information aligns with the expected map display.

Testing

Describe the testing process and any specific scenarios or cases that were tested to ensure the fix is effective.

Screenshots:

image

Related Issue

@KatiaGhezali KatiaGhezali self-assigned this Nov 27, 2023
@KatiaGhezali KatiaGhezali linked an issue Nov 27, 2023 that may be closed by this pull request
5 tasks
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
student-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 2:54am

Copy link
Contributor

@hocine1212 hocine1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Copy link
Contributor

@Ben-Tewfik Ben-Tewfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@Ben-Tewfik Ben-Tewfik merged commit c1860c9 into develop Nov 27, 2023
5 checks passed
@Ben-Tewfik Ben-Tewfik deleted the 175-fix-window-undefined-issue branch November 27, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "window undefined" issue
3 participants