generated from 202306-NEA-DZ-FEW/capstone-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix window undefined issue #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatiaGhezali
requested review from
samiba6,
hocine1212,
Ben-Tewfik,
khaoulasara and
MouniaBelkheir
November 27, 2023 01:59
5 tasks
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hocine1212
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
Ben-Tewfik
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Fix Window Undefined Bug in Map Component
Pull Request Description
The error encountered was due to the fact that react-leaflet relies on the Leaflet library, and server-side rendering (SSR) is incompatible with Leaflet.
Changes Made
Investigated the root cause of the window undefined bug.
Identified the specific part of the code causing the issue.
Temporarily replaced Firebase data retrieval with hardcoded information.
Tested the map component to ensure the bug is resolved.
Checked if the hardcoded information aligns with the expected map display.
Testing
Describe the testing process and any specific scenarios or cases that were tested to ensure the fix is effective.
Screenshots:
Related Issue